fix: popper scroll issue #712
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like this has some very slight changes in the screenshots. Particularly with the box-shadow.
|
Codecov Report
@@ Coverage Diff @@
## master #712 +/- ##
==========================================
+ Coverage 74.80% 75.16% +0.35%
==========================================
Files 264 280 +16
Lines 8514 8842 +328
Branches 1709 1759 +50
==========================================
+ Hits 6369 6646 +277
- Misses 2093 2138 +45
- Partials 52 58 +6
Continue to review full report at Codecov.
|
|
I've also noticed that some screenshots appear to be slightly smaller in width. Notice the sliver of transparency on the left edge of the new screenshot. But yet the dimensions are identical. I saw this on #629 as well. Any ideas? Maybe it's just a github thing.
|
markov00
pushed a commit
that referenced
this pull request
Jun 16, 2020
## [19.5.1](v19.5.0...v19.5.1) (2020-06-16) ### Bug Fixes * graceful scale fallbacks and warnings ([#704](#704)) ([ed49bbb](ed49bbb)), closes [#678](#678) * **axis:** rotated label positioning ([#709](#709)) ([2e26430](2e26430)), closes [#673](#673) * **tooltip:** popper scroll issue ([#712](#712)) ([0c97c67](0c97c67))
|
🎉 This PR is included in version 19.5.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
1 task
AMoo-Miki
pushed a commit
to AMoo-Miki/OpenSearch-Dashboards
that referenced
this pull request
Feb 10, 2022
## [19.5.1](elastic/elastic-charts@v19.5.0...v19.5.1) (2020-06-16) ### Bug Fixes * graceful scale fallbacks and warnings ([opensearch-project#704](elastic/elastic-charts#704)) ([fe8e322](elastic/elastic-charts@fe8e322)), closes [opensearch-project#678](elastic/elastic-charts#678) * **axis:** rotated label positioning ([opensearch-project#709](elastic/elastic-charts#709)) ([7146799](elastic/elastic-charts@7146799)), closes [opensearch-project#673](elastic/elastic-charts#673) * **tooltip:** popper scroll issue ([opensearch-project#712](elastic/elastic-charts#712)) ([54ed46b](elastic/elastic-charts@54ed46b))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix scroll bar issue with popper js